From 174375be1bbbb17b6968bde2c283254726aaba18 Mon Sep 17 00:00:00 2001 From: Toshit Chawda Date: Fri, 13 Dec 2024 20:30:43 -0800 Subject: [PATCH] show more info in js rewrite err --- rewriter/rewriter/src/lib.rs | 2 +- src/shared/rewriters/js.ts | 25 ++++++++++++++++--------- 2 files changed, 17 insertions(+), 10 deletions(-) diff --git a/rewriter/rewriter/src/lib.rs b/rewriter/rewriter/src/lib.rs index 675a968..df71c5c 100644 --- a/rewriter/rewriter/src/lib.rs +++ b/rewriter/rewriter/src/lib.rs @@ -1,7 +1,7 @@ use std::ops::Range; use cfg::Config; -use changes::{JsChangeResult, JsChanges, Rewrite}; +use changes::{JsChangeResult, JsChanges}; use oxc::{ allocator::Allocator, ast::Visit, diff --git a/src/shared/rewriters/js.ts b/src/shared/rewriters/js.ts index 2b0e0da..1c5296e 100644 --- a/src/shared/rewriters/js.ts +++ b/src/shared/rewriters/js.ts @@ -26,15 +26,22 @@ function rewriteJsWrapper( ): string | ArrayBuffer { let out: RewriterOutput; const before = performance.now(); - if (typeof input === "string") { - out = rewrite_js(input, meta.base.href, url || "(unknown)", $scramjet); - } else { - out = rewrite_js_from_arraybuffer( - new Uint8Array(input), - meta.base.href, - url || "(unknown)", - $scramjet - ); + try { + if (typeof input === "string") { + out = rewrite_js(input, meta.base.href, url || "(unknown)", $scramjet); + } else { + out = rewrite_js_from_arraybuffer( + new Uint8Array(input), + meta.base.href, + url || "(unknown)", + $scramjet + ); + } + } catch (err) { + let err1 = err as Error; + console.error("failed rewriting js for", url, err1, input); + err1.message = `failed rewriting js for "${url}": ${err1.message}`; + throw err1; } const after = performance.now(); const { js, errors, duration } = out;