implement direct and indirect eval

This commit is contained in:
velzie 2024-07-28 21:45:41 -04:00
parent e6b237c525
commit ec8421be8f
No known key found for this signature in database
GPG key ID: 048413F95F0DDE1F
12 changed files with 171 additions and 101 deletions

View file

@ -2,8 +2,8 @@ pub mod rewrite;
use std::{panic, str::FromStr};
use js_sys::Function;
use rewrite::{rewrite, EncodeFn};
use js_sys::{Function, Object, Reflect};
use rewrite::{rewrite, Config, EncodeFn};
use url::Url;
use wasm_bindgen::prelude::*;
@ -30,42 +30,58 @@ fn create_encode_function(encode: Function) -> EncodeFn {
}
#[wasm_bindgen]
pub fn rewrite_js(
js: &str,
url: &str,
prefix: String,
encode: Function,
wrapfn: String,
importfn: String,
) -> Vec<u8> {
pub fn rewrite_js(js: &str, url: &str, config: Object) -> Vec<u8> {
rewrite(
js,
Url::from_str(url).unwrap(),
prefix,
create_encode_function(encode),
wrapfn,
importfn,
Config {
prefix: Reflect::get(&config, &"prefix".into())
.unwrap()
.as_string()
.unwrap(),
encode: create_encode_function(Reflect::get(&config, &"encode".into()).unwrap().into()),
wrapfn: Reflect::get(&config, &"wrapfn".into())
.unwrap()
.as_string()
.unwrap(),
importfn: Reflect::get(&config, &"importfn".into())
.unwrap()
.as_string()
.unwrap(),
rewritefn: Reflect::get(&config, &"rewritefn".into())
.unwrap()
.as_string()
.unwrap(),
},
)
}
#[wasm_bindgen]
pub fn rewrite_js_from_arraybuffer(
js: &[u8],
url: &str,
prefix: String,
encode: Function,
wrapfn: String,
importfn: String,
) -> Vec<u8> {
pub fn rewrite_js_from_arraybuffer(js: &[u8], url: &str, config: Object) -> Vec<u8> {
// we know that this is a valid utf-8 string
let js = unsafe { std::str::from_utf8_unchecked(js) };
rewrite(
js,
Url::from_str(url).unwrap(),
prefix,
create_encode_function(encode),
wrapfn,
importfn,
Config {
prefix: Reflect::get(&config, &"prefix".into())
.unwrap()
.as_string()
.unwrap(),
encode: create_encode_function(Reflect::get(&config, &"encode".into()).unwrap().into()),
wrapfn: Reflect::get(&config, &"wrapfn".into())
.unwrap()
.as_string()
.unwrap(),
importfn: Reflect::get(&config, &"importfn".into())
.unwrap()
.as_string()
.unwrap(),
rewritefn: Reflect::get(&config, &"rewritefn".into())
.unwrap()
.as_string()
.unwrap(),
},
)
}

View file

@ -11,6 +11,8 @@ pub mod rewrite;
use rewrite::rewrite;
use url::Url;
use crate::rewrite::Config;
// Instruction:
// create a `test.js`,
// run `cargo run -p oxc_parser --example visitor`
@ -112,10 +114,13 @@ fn main() -> std::io::Result<()> {
rewrite(
&source_text,
Url::from_str("https://google.com/glorngle/si.js").unwrap(),
"/scrammedjet/".to_string(),
Box::new(encode_string),
"$wrap".to_string(),
"$import".to_string(),
Config {
prefix: "/scrammedjet/".to_string(),
encode: Box::new(encode_string),
wrapfn: "$wrap".to_string(),
importfn: "$import".to_string(),
rewritefn: "$rewrite".to_string(),
}
)
.as_slice()
)

View file

@ -30,18 +30,24 @@ pub type EncodeFn = Box<dyn Fn(String) -> String>;
struct Rewriter {
jschanges: Vec<JsChange>,
base: Url,
prefix: String,
wrapfn: String,
importfn: String,
encode: EncodeFn,
config: Config,
}
pub struct Config {
pub prefix: String,
pub wrapfn: String,
pub importfn: String,
pub rewritefn: String,
pub encode: EncodeFn,
}
impl Rewriter {
fn rewrite_url(&mut self, url: String) -> String {
let url = self.base.join(&url).unwrap();
let urlencoded = (self.encode)(url.to_string());
let urlencoded = (self.config.encode)(url.to_string());
format!("\"{}{}\"", self.prefix, urlencoded)
format!("\"{}{}\"", self.config.prefix, urlencoded)
}
}
@ -57,24 +63,49 @@ impl<'a> Visit<'a> for Rewriter {
if UNSAFE_GLOBALS.contains(&it.name.to_string().as_str()) {
self.jschanges.push(JsChange::GenericChange {
span: it.span,
text: format!("({}({}))", self.wrapfn, it.name),
text: format!("({}({}))", self.config.wrapfn, it.name),
});
}
}
fn visit_this_expression(&mut self, it: &oxc_ast::ast::ThisExpression) {
self.jschanges.push(JsChange::GenericChange {
span: it.span,
text: format!("({}(this))", self.wrapfn),
text: format!("({}(this))", self.config.wrapfn),
});
}
fn visit_debugger_statement(&mut self, it: &oxc_ast::ast::DebuggerStatement) {
// delete debugger statements entirely. some sites will spam debugger as an anti-debugging measure, and we don't want that!
self.jschanges.push(JsChange::GenericChange {
span: it.span,
text: "".to_string(),
});
}
// we can't overwrite window.eval in the normal way because that would make everything an
// indirect eval, which could break things. we handle that edge case here
fn visit_call_expression(&mut self, it: &oxc_ast::ast::CallExpression<'a>) {
if let Expression::Identifier(s) = &it.callee {
// if it's optional that actually makes it an indirect eval which is handled separately
if s.name == "eval" && !it.optional {
self.jschanges.push(JsChange::GenericChange {
span: Span::new(s.span.start, s.span.end + 1),
text: format!("eval({}(", self.config.rewritefn),
});
self.jschanges.push(JsChange::GenericChange {
span: Span::new(it.span.end, it.span.end),
text: ")".to_string(),
});
// then we walk the arguments, but not the callee, since we want it to resolve to
// the real eval
walk::walk_arguments(self, &it.arguments);
return;
}
}
walk::walk_call_expression(self, it);
}
fn visit_import_declaration(&mut self, it: &oxc_ast::ast::ImportDeclaration<'a>) {
let name = it.source.value.to_string();
let text = self.rewrite_url(name);
@ -87,7 +118,7 @@ impl<'a> Visit<'a> for Rewriter {
fn visit_import_expression(&mut self, it: &oxc_ast::ast::ImportExpression<'a>) {
self.jschanges.push(JsChange::GenericChange {
span: Span::new(it.span.start, it.span.start + 6),
text: format!("({}(\"{}\"))", self.importfn, self.base),
text: format!("({}(\"{}\"))", self.config.importfn, self.base),
});
walk::walk_import_expression(self, it);
}
@ -122,7 +153,7 @@ impl<'a> Visit<'a> for Rewriter {
if UNSAFE_GLOBALS.contains(&s.name.to_string().as_str()) && p.shorthand {
self.jschanges.push(JsChange::GenericChange {
span: s.span,
text: format!("{}: ({}({}))", s.name, self.wrapfn, s.name),
text: format!("{}: ({}({}))", s.name, self.config.wrapfn, s.name),
});
return;
}
@ -238,7 +269,7 @@ fn expression_span(e: &Expression) -> Span {
}
// js MUST not be able to get a reference to any of these because sbx
const UNSAFE_GLOBALS: [&str; 8] = [
const UNSAFE_GLOBALS: [&str; 9] = [
"window",
"self",
"globalThis",
@ -247,16 +278,10 @@ const UNSAFE_GLOBALS: [&str; 8] = [
"top",
"location",
"document",
"eval",
];
pub fn rewrite(
js: &str,
url: Url,
prefix: String,
encode: EncodeFn,
wrapfn: String,
importfn: String,
) -> Vec<u8> {
pub fn rewrite(js: &str, url: Url, config: Config) -> Vec<u8> {
let allocator = Allocator::default();
let source_type = SourceType::default();
let ret = Parser::new(&allocator, js, source_type).parse();
@ -274,10 +299,7 @@ pub fn rewrite(
let mut ast_pass = Rewriter {
jschanges: Vec::new(),
base: url,
prefix,
encode,
wrapfn,
importfn,
config,
};
ast_pass.visit_program(&program);